-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor macOS build pipeline #325
Conversation
There are parts of this (like missing hyphens) that seem like they shouldn't work to me, but if it works, I guess it works? /cc: @MiYanni for a look if you have time. |
I think your're right, and that syntax was incorrect for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review the original PR that added these jobs, but this solution to use a strategy matrix looks much cleaner for this repo's pipeline.
Simplifies the workflow of macOS builds to make it easier to extend afterwards (e.g., adding signing, notarization, etc)