Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor macOS build pipeline #325

Merged
merged 9 commits into from
Feb 3, 2025
Merged

Refactor macOS build pipeline #325

merged 9 commits into from
Feb 3, 2025

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Jan 31, 2025

Simplifies the workflow of macOS builds to make it easier to extend afterwards (e.g., adding signing, notarization, etc)

@edvilme edvilme changed the title (Draft) ci/cd mac loop architectures Refactor macOS build pipeline Jan 31, 2025
@edvilme edvilme marked this pull request as ready for review January 31, 2025 22:17
@edvilme edvilme requested a review from a team January 31, 2025 22:17
@Forgind
Copy link
Member

Forgind commented Feb 3, 2025

There are parts of this (like missing hyphens) that seem like they shouldn't work to me, but if it works, I guess it works? /cc: @MiYanni for a look if you have time.

@edvilme
Copy link
Member Author

edvilme commented Feb 3, 2025

There are parts of this (like missing hyphens) that seem like they shouldn't work to me, but if it works, I guess it works? /cc: @MiYanni for a look if you have time.

I think your're right, and that syntax was incorrect for .vsts-ci.yml which doesn't run on the PR. Fixed it now :)

https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/jobs-job-strategy?view=azure-pipelines

Copy link
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the original PR that added these jobs, but this solution to use a strategy matrix looks much cleaner for this repo's pipeline.

@edvilme edvilme merged commit 0cc67a3 into main Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants